chore: cleaning up test for ViewReport.cy.tsx #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@JessicaSachs LGTM (aha faker in action, cool), but we need also the same for ansi colored tests, the original PR was to include the support via |
|
@userquin want to send another PR for your changes? |
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Co-authored-by: Jelf <[email protected]> Co-authored-by: Anthony Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the tests for
ViewReport.cy.tsxand begins to add faker in for more realistic test data.There is one loss of coverage: we no longer check that a b tag is the element used in the DOM. For this, we should be using Percy for making sure that the styles are correct. Percy has a free, open-source plan.