Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix server hmr port conflict #8197

Merged
merged 1 commit into from
May 17, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 17, 2022

Description

Similar to #7523 but for hmr port.

Ideally, it should use the next unused port instead but it will require more work so I didn't do it in this PR.
Also I feel it curious to silent EADDRINUSE for ws server. 🤔

wss.on('error', (e: Error & { code: string }) => {
if (e.code !== 'EADDRINUSE') {
config.logger.error(
colors.red(`WebSocket server error:\n${e.stack || e.message}`),
{ error: e }
)
}
})

Steps to reproduce

  1. Edit playground/ssr-react/server.js line 90 app.listen(5173, () => { to app.listen(5174, () => {.
  2. Run pnpm dev in playground/ssr-vue
  3. Run pnpm dev in playground/ssr-react
  4. Edit playground/ssr-react/src/pages/Home.jsx
  5. HMR does not happen

Additional context

It does not affect CI because only one thread is used with CI.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 17, 2022
@bluwy
Copy link
Member

bluwy commented May 17, 2022

Nicee it's working for me too. Maybe it's still worth looking into auto-increment the the hmr port, but I think this is fine for now to get local tests running properly. And also, maybe this is the reason we can't run multiple threads on CI? So we can tune it up now 🤔

@patak-dev patak-dev merged commit 8d478df into vitejs:main May 17, 2022
@sapphi-red sapphi-red deleted the test/fix-server-hmr-port-conflict branch May 18, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants