Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix eslint invalid ecmaVersion value #5052

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

Shinigami92
Copy link
Member

Description

The configured parserOptions.ecmaVersion value is not known / invalid.
This results in false-positive reports.

Additional context

#5021
eslint/eslint#15022 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added bug p1-chore Doesn't change code behavior (priority) labels Sep 23, 2021
@Shinigami92 Shinigami92 self-assigned this Sep 23, 2021
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot that we are using the typescript-eslint parser 😂
I only checked that the default eslint parser supports this value.

@ygj6
Copy link
Member

ygj6 commented Sep 24, 2021

My fault, I just check the eslint document and thought it had latest value. Also, I didn't get the error hint on my IDE. 😥

@patak-dev
Copy link
Member

Dont worry, we also reviewed the PR and missed this

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants