fix: defaultRequestToFile should handle uncached node_modules request #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csr632
commented
May 22, 2020
src/node/resolver.ts
Outdated
| } | ||
| const resolved = resolveNodeModuleFile(root, id) | ||
| if (!resolved) throw new Error(`Can't resolve "${id}"`) |
There was a problem hiding this comment.
It doesn't make sense to continue, so I throw here. Is there a better choice?
There was a problem hiding this comment.
It will eventually error elsewhere, it's better to let it pass through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #228
Let me explain with this reproduce repo: https://github.com/csr632/test-vite/tree/wrong-resolve
When dev server is re-writing this module: test-package/es/index.js
vite go to this line:
https://github.com/csr632/vite/blob/ada8886e36578c7f43b7cd12bacd65e5a7c4c6e4/src/node/server/serverPluginModuleRewrite.ts#L243
with pathname being "/@modules/test-package/es/nested", which is not cached by idToFileMap:https://github.com/csr632/vite/blob/e786897134cb35ca19f4358c2829a82a1b3269e7/src/node/resolver.ts#L28
Previously defaultRequestToFile do nothing when this happen, and return
path.join(root, publicPath.slice(1)), which doesn't make sense because publicPath is something like/@modules/test-package/es/nested.