Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): don't externalize transitive dep package name with asset extension #18152

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Sep 20, 2024

Description

#16242 handled the case of require call, but it looks like it should cover import as well. This was suggested in #16242 (comment) and probably this is indeed necessary to handle external package name like import "some-package.pdf".

Copy link

stackblitz bot commented Sep 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review September 20, 2024 07:42
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Sep 26, 2024
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

@hi-ogawa
Copy link
Collaborator Author

/ecosystem-ci run sveltekit

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on b4910a9: Open

sveltekit

@hi-ogawa
Copy link
Collaborator Author

I reran sveltekit and CI passed, so it was probably a flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
3 participants