-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(optimizer): don't externalize transitive dep package name with asset extension #18152
fix(optimizer): don't externalize transitive dep package name with asset extension #18152
Conversation
Run & review this pull request in StackBlitz Codeflow. |
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
/ecosystem-ci run sveltekit |
I reran sveltekit and CI passed, so it was probably a flake. |
Description
#16242 handled the case of
require
call, but it looks like it should coverimport
as well. This was suggested in #16242 (comment) and probably this is indeed necessary to handle external package name likeimport "some-package.pdf"
.