Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use config.consumer instead of options?.ssr / config.build.ssr #18140

Merged

Conversation

sapphi-red
Copy link
Member

Description

Replaced options?.ssr and config.build.ssr with config.consumer === 'server'.

I didn't actually face any issues but found it while reading the code.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: environment API Vite Environment API labels Sep 19, 2024
Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

@patak-dev patak-dev merged commit 21ec1ce into vitejs:main Sep 19, 2024
12 checks passed
@sapphi-red sapphi-red deleted the fix/use-config-consumer-instead-of-ssr branch September 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants