ci(link-check): check docs dead link #17506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR @baicie! We discussed this with @bluwy and @brc-dd and we think that it is better to avoid checking every link on each commit. Doing all these requests seems a bit wasteful given that we will be checking them constantly. There are services like https://www.screamingfrog.co.uk/seo-spider/ that could be used. Maybe there are some free alternatives for OSS projects. For now, I think we can't just rely on Vite users and contributors. The docs has a lot of traffic and as soon as there are is a broken link, we get a quick fix from the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check docs dead http/https link