-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assetsInclude=[]
in vite config causes extra file generation and path complications
#10926
Comments
assetsInclude
causes extra file generation and path complicationsassetsInclude=[]
in vite config causes extra file generation and path complications
Looks like it's because the empty array is passed to here as-is: vite/packages/vite/src/node/config.ts Lines 534 to 536 in 6462ab0
which equals to |
Hello @colearendt. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it! |
* fix(config): exclude config.assetsInclude empty array (#10941) fixes #10926 * feat(css): upgrade postcss-modules (#10987) * fix(mpa): support mpa fallback (#10985) fixes #10966 * fix: export preprocessCSS in CJS (#11067) * chore: update license Co-authored-by: sun0day <[email protected]> Co-authored-by: Jason Quense <[email protected]> Co-authored-by: sun0day <[email protected]>
Describe the bug
Using
vite-plugin-web-extension
to create a web extension, I happened upon very strange behavior. Namely,src/popup/popup.html
, then output atdist/popup.html
export default "/popup.html"
The fix for this behavior was to remove the following line from my
vite.config.ts
(which was there as a placeholder):Reproduction
https://github.com/colearendt/extensions-example
Steps to reproduce
npm run build
dist/popup.html
file with contents:export default "/popup.html"%
assetsInclude: []
line fromvite.config.ts
dist/popup.html
has expected contentsSystem Info
Used Package Manager
npm
Logs
Validations
The text was updated successfully, but these errors were encountered: