test: wait networkidle before assert (#17442)

vitejs · Jun 11, 2024 · ceb5f43 · ceb5f43
1 parent d6a174f
commit ceb5f43
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/playground/fs-serve/__tests__/base/fs-serve-base.spec.ts b/playground/fs-serve/__tests__/base/fs-serve-base.spec.ts
@@ -8,7 +8,11 @@ const stringified = JSON.stringify(testJSON)
 describe.runIf(isServe)('main', () => {
  beforeAll(async () => {
  const srcPrefix = viteTestUrl.endsWith('/') ? '' : '/'
- await page.goto(viteTestUrl + srcPrefix + 'src/')
+ await page.goto(viteTestUrl + srcPrefix + 'src/', {
+ // while networkidle is discouraged, we use here because we're not using playwright's retry-able assertions,
+ // and refactoring the code below to manually retry would be harder to read.
+ waitUntil: 'networkidle',
+ })
  })
 
  test('default import', async () => {