feat: vitest deps.experimentalOptimizer #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
force-pushed
the
vitest-experimentalOptimizer
branch
from
4a365d6
to
f23d687
Compare
ArnaudBarre
force-pushed
the
vitest-experimentalOptimizer
branch
from
f23d687
to
78da7d8
Compare
|
@patak-dev So this is failing. Should we continue in this direction or find another way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So actually this change is less safer than I though because it can break people using testing Vite HMR like @brillout.
I will merge this now and see the result in ecosystem CI tomorrow. My current idea is that this is rare and asking few framework authors to set this variable is ok.
Another more long term fix could be for vitest to add a flag in the transform call (like
ssr) so that plugin can adapt more properly to this case.Related PR in the SWC plugin. Original issue: vitejs/vite-plugin-react-swc#111