Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exploration zoom WIP #1575

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Exploration zoom WIP #1575

wants to merge 1 commit into from

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 7, 2024

Short exploration to see if a zoom feature would be possible/useful
for dashboards.

  • Buttons allow to zoom in / out
  • Chart interactivity is disabled when zoomed out
  • Allow to zoom in again on charts on click
  • Show canvas outline
  • Overview button that shows everything at once

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 10:46am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

A few thoughts:

  • I initially expected to be able to interact with charts when zooming out, especially that there is a blue outline when hovering over them,
  • also at first I thought that the whole canvas area extends, so I could have more charts on the sides 😅 would it make sense to add canvas outline when zooming out, so it's more clear that the canvas area stays "fixed"?
  • also a thought it we actually need 0.25x and 0.5x; maybe it also would make sense to have an "overview" button that would always show all charts and dynamically adjust the scale?

This is just to write things down, the implementation looks good 💯

@ptbrowne
Copy link
Collaborator Author

ptbrowne commented Jun 7, 2024

Sorry should have been a draft PR. It was mostly to get feedback and allow @KerstinFaye to see it.

  • Yes you should be able to click back on the chart to zoom in again, this is why I added the outline on the charts
  • Good idea to have the canvas outline 👍
  • Yes I had a similar idea, seems good 👍

@ptbrowne ptbrowne marked this pull request as draft June 7, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants