Merge pull request #691 from visualize-admin/fix/cypress-tests

Fix cypress tests
visualize-admin · Sep 8, 2022 · d473312 · d473312 · vercel · Sep 8, 2022
2 parents 2875f85 + 8198a9e
commit d473312
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 15 deletions.
diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml
@@ -55,13 +55,26 @@ jobs:
           start: "env PORT=3333 npm run start"
           wait-on: "https://localhost:3333"
           record: false
-      - name: Set argos upload branch on master branch
-        run: echo "ARGOS_BRANCH=master" >> $GITHUB_ENV
-        if: github.ref == 'refs/heads/main'
-      - name: Set argos upload branch on PR branches
-        run: echo "ARGOS_BRANCH=$GITHUB_HEAD_REF" >> $GITHUB_ENV
-        if: github.ref != 'refs/heads/main'
-      - name: Upload screenshots
-        env:
-          ARGOS_TOKEN: ${{ secrets.ARGOS_TOKEN }}
-        run: yarn run argos upload --commit $GITHUB_SHA --branch $ARGOS_BRANCH  cypress/screenshots
+      - name: Upload Cypress screenshots
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: cypress-screenshots
+          path: cypress/screenshots
+      # Test run video was always captured, so this action uses "always()" condition
+      - name: Upload Cypress videos
+        uses: actions/upload-artifact@v2
+        if: always()
+        with:
+          name: cypress-videos
+          path: cypress/videos
+      # - name: Set argos upload branch on master branch
+      #   run: echo "ARGOS_BRANCH=master" >> $GITHUB_ENV
+      #   if: github.ref == 'refs/heads/main'
+      # - name: Set argos upload branch on PR branches
+      #   run: echo "ARGOS_BRANCH=$GITHUB_HEAD_REF" >> $GITHUB_ENV
+      #   if: github.ref != 'refs/heads/main'
+      # - name: Upload screenshots
+      #   env:
+      #     ARGOS_TOKEN: ${{ secrets.ARGOS_TOKEN }}
+      #   run: yarn run argos upload --commit $GITHUB_SHA --branch $ARGOS_BRANCH  cypress/screenshots
diff --git a/cypress/integration/edition.spec.ts b/cypress/integration/edition.spec.ts
@@ -28,11 +28,9 @@ describe("Editing a chart", () => {
     cy.findByText("Filters", {
       selector: "button",
     }).click();
-    cy.findByText("Military defence").click();
-    cy.findByText("Civil defence").click();
-    cy.findByText("Mining, manufacturing and construction").click();
-    cy.findByText("Transport").click();
-    cy.findByText("Communication").click();
+    cy.findByText("Economic affairs").click();
+    cy.findByText("Social protection").click();
+    cy.findByText("Health").click();
     cy.findByText("Apply filters").click();
 
     cy.get('[data-name="panel-middle"]').scrollTo(0, 200, {