Skip to content

Commit

Permalink
chore: fix hardcoded strings
Browse files Browse the repository at this point in the history
  • Loading branch information
vishal2376 committed Apr 6, 2024
1 parent 9f52c40 commit 32334c6
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ fun AboutScreen(
)

Text(
text = "Source Code",
text = stringResource(R.string.source_code),
modifier = Modifier
.fillMaxWidth()
.clickable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,30 @@ import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import com.vishal2376.snaptick.R
import com.vishal2376.snaptick.presentation.common.h3TextStyle
import com.vishal2376.snaptick.presentation.common.infoTextStyle

@Composable
fun FeaturesComponent(modifier: Modifier = Modifier) {
Column(
modifier = modifier
.padding(32.dp,0.dp)
.verticalScroll(rememberScrollState())
, verticalArrangement = Arrangement.spacedBy(8.dp)
.padding(32.dp, 0.dp)
.verticalScroll(rememberScrollState()), verticalArrangement = Arrangement.spacedBy(8.dp)
) {
FeatureItem(icon = "📝", text = "Create and Edit Tasks")
FeatureItem(icon = "⏲️", text = "Pomodoro Timer")
FeatureItem(icon = "🔄", text = "Sort Tasks")
FeatureItem(icon = "", text = "Analyze Free Time")
FeatureItem(icon = "😴", text = "Set Sleep Time")
FeatureItem(icon = "🗓️", text = "Manage tasks in Calendar View")
FeatureItem(icon = "🔁", text = "Repeatable Tasks with Notification")
FeatureItem(icon = "🎬", text = "Smooth Animations")
FeatureItem(icon = "🎨", text = "Modern UI with Cool Themes")
FeatureItem(icon = "🌐", text = "Available in 15+ Languages")
FeatureItem(icon = "🧩", text = "Create Widgets")
FeatureItem(icon = "📝", text = stringResource(R.string.create_and_edit_tasks))
FeatureItem(icon = "⏲️", text = stringResource(R.string.pomodoro_timer))
FeatureItem(icon = "🔄", text = stringResource(R.string.sort_tasks))
FeatureItem(icon = "", text = stringResource(R.string.analyze_free_time))
FeatureItem(icon = "😴", text = stringResource(R.string.set_sleep_time))
FeatureItem(icon = "🗓️", text = stringResource(R.string.manage_tasks_in_calendar_view))
FeatureItem(icon = "🔁", text = stringResource(R.string.repeatable_tasks_with_notification))
FeatureItem(icon = "🎬", text = stringResource(R.string.smooth_animations))
FeatureItem(icon = "🎨", text = stringResource(R.string.modern_ui_with_cool_themes))
FeatureItem(icon = "🌐", text = stringResource(R.string.available_in_15_languages))
FeatureItem(icon = "🧩", text = stringResource(R.string.create_widgets))
}
}

Expand Down
11 changes: 11 additions & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,15 @@
<string name="glance_preview_random_time" translatable="false">12:00am - 1:00pm</string>
<string name="app_description">Snaptick is an MVVM Jetpack Compose app, offering ad-free task management with a built-in pomodoro timer to help you organize your daily plans</string>
<string name="features">Features</string>
<string name="source_code">Source Code</string>
<string name="create_and_edit_tasks">Create and Edit Tasks</string>
<string name="pomodoro_timer">Pomodoro Timer</string>
<string name="sort_tasks">Sort Tasks</string>
<string name="create_widgets">Create Widgets</string>
<string name="available_in_15_languages">Available in 15+ Languages</string>
<string name="modern_ui_with_cool_themes">Modern UI with Cool Themes</string>
<string name="smooth_animations">Smooth Animations</string>
<string name="repeatable_tasks_with_notification">Repeatable Tasks with Notification</string>
<string name="manage_tasks_in_calendar_view">Manage tasks in Calendar View</string>
<string name="analyze_free_time">Analyze Free Time</string>
</resources>

0 comments on commit 32334c6

Please sign in to comment.