[ES-7453] support multiple placements #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Ticket CheckFound the corresponding Jira issues: |
Sensitive Data ScanThis PR doesn't seem to contain any sensitive data. |
thehung111
reviewed
Apr 28, 2023
| @@ -24,11 +24,6 @@ open class ViProductSearch : NSObject { | |||
|
|
|||
| private var client : ViProductSearchClient? = nil | |||
|
|
|||
| /// Default Constructor | |||
| private override init() { | |||
There was a problem hiding this comment.
why do this? the setup() method is the same as init. app key and placement ID are mandatory.
There was a problem hiding this comment.
nvm get what u tried to do
thehung111
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.