Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14: Certificate Formatting #17

Merged
merged 1 commit into from
Oct 10, 2023
Merged

14: Certificate Formatting #17

merged 1 commit into from
Oct 10, 2023

Conversation

larrydewey
Copy link
Contributor

  • Adds in logic to attempt to meet the provided format specified on the CLI.

Resolves: #14

@larrydewey
14: Certificate Formatting
edfc5c5 
- Adds in logic to attempt to meet the provided
  format specified on the CLI.

Signed-off-by: Larry Dewey <[email protected]>
@auto-assign auto-assign bot requested a review from ryansavino October 10, 2023 14:00
ryansavino
ryansavino approved these changes Oct 10, 2023
View reviewed changes
Copy link

@ryansavino ryansavino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code with Larry

DGonzalezVillal
DGonzalezVillal approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larrydewey larrydewey merged commit 90f3675 into virtee:main Oct 10, 2023
9 checks passed
@larrydewey larrydewey deleted the 14-export-keys branch October 10, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansavino ryansavino ryansavino approved these changes

@DGonzalezVillal DGonzalezVillal DGonzalezVillal approved these changes

@tylerfanelli tylerfanelli Awaiting requested review from tylerfanelli tylerfanelli is a code owner

Assignees

@ryansavino ryansavino

@DGonzalezVillal DGonzalezVillal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export subcommand ignores encoding-fmt arg
3 participants
@larrydewey @ryansavino @DGonzalezVillal