Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Expand testing #230

Closed
vintagepc opened this issue Aug 30, 2020 · 3 comments · Fixed by #231
Closed

[FEATURE] Expand testing #230

vintagepc opened this issue Aug 30, 2020 · 3 comments · Fixed by #231
Labels
enhancement New feature or request
Milestone

Comments

@vintagepc
Copy link
Owner

vintagepc commented Aug 30, 2020

Describe the solution you'd like
Expand the automated testing to cover more of the code.

Just start simple with something that runs on a system with GL, deal with the headless build runners later... PPM seems like a nice convenient format.

It should:

  • exercise the GL draw code
    AND
  • take snapshots?
  • Compare them to a reference?
    OR
  • Inspect key pixels to make sure the visual looks like it should. May be easier with some drawables than others.
    OR
  • Maybe intercept the GL calls for things like characters rendered to screen?

Additional context
Useful links for automated GL testing...
https://github.com/openrndr/setup-opengl

https://github.com/cirosantilli/cpp-cheat/blob/70b22ac36f92e93c94f951edb8b5af7947546525/opengl/offscreen.c

https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glReadPixels.xhtml

https://github.com/mesa3d/piglit

https://pdiff.sourceforge.net/

@vintagepc vintagepc added the enhancement New feature or request label Aug 30, 2020
@vintagepc
Copy link
Owner Author

Looks like EGL is required to run headless on the build server without opening a window... GLUT needs one.

@vintagepc
Copy link
Owner Author

@DRracer This one (and the upcoming associated PR, #231) should be of particular interest to you, it adds and makes use of extensive scripting and verification capability for components, telemetry, and tests. So while it serves as unit tests for the simulator, it should be more than suited to automated evaluation of firmware behaviour prior to release!

@DRracer
Copy link
Collaborator

DRracer commented Sep 12, 2020

@vintagepc well done, making a note for the upcoming FW release - we'll try it. Thanks for notifying me.

@vintagepc vintagepc added this to the 1.0 milestone Sep 12, 2020
vintagepc added a commit that referenced this issue Sep 13, 2020
* add a GL testing helper
* add GL test functionality, extensive tests
* Fix #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants