Avoid multiply defined s_2_ws linker error
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0959c5
to
848c025
Compare
615f7ea
to
048375b
Compare
|
Please merge this, encountered this issue and had to waste hours to debug. |
zlnimda
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Minimal changes and it resolves the current bug with mio with lastest cpp standard.
Tested and approved on my end on personal project.
Please @mandreyel, if you have time: can you merge this pull request ?
|
@mandreyel ping |
+ use std::wstring directly without intermediate std::vector in `s_2_ws` fixes vimpunk#87
048375b
to
fd9dc4b
Compare
beats-dh
approved these changes
Feb 15, 2023
|
@mandreyel, please look this. It's breaking the lib in the vcpkg repository. microsoft/vcpkg#29370 |
This was referenced Mar 2, 2023
glanderson42
approved these changes
Mar 3, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s_2_wsfixes #87