Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

RawGenericField functional test #159

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Conversation

anthonycr
Copy link
Contributor

Issue

Summary

Adding a functional test for the new raw type test case RawGenericField.

How to Test

CI will run the tests.

cc @mcumings

@anthonycr anthonycr requested a review from msya January 10, 2018 15:03
@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #159 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #159   +/-   ##
==========================================
  Coverage      76.79%   76.79%           
  Complexity       339      339           
==========================================
  Files             23       23           
  Lines           1780     1780           
  Branches         272      272           
==========================================
  Hits            1367     1367           
  Misses           297      297           
  Partials         116      116

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215b3a6...0a4f8c7. Read the comment docs.

@mcumings
Copy link

Isn't this redundant? i.e., in order to compile the test, the class in question would have to be compiled. Or are you just using this as documentation?

@anthonycr
Copy link
Contributor Author

It's technically redundant, since in order to run the integration tests in the integration-test-java module it must compile, but the functional tests provide test coverage as they are part of the stag-library-compiler module. Ideally at some point I will find a way to put non compiling code into the integration-test-java module and then run integration and functional tests separately.

Copy link

@msya msya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthonycr anthonycr merged commit 58115f0 into develop Jan 12, 2018
@anthonycr anthonycr deleted the functional-test-raw-type branch January 12, 2018 15:45
@mcumings
Copy link

Gotcha. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants