Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast documentation for readability #9128

Closed
imme-emosol opened this issue Jan 17, 2023 · 5 comments
Closed

Improve contrast documentation for readability #9128

imme-emosol opened this issue Jan 17, 2023 · 5 comments

Comments

@imme-emosol
Copy link

My browser is set to use different background-color & color.

Psalm's documentation seems to set a foreground-/text-color but not a background-color.

An example of what my browser shows:
image

@psalm-github-bot
Copy link

Hey @imme-emosol, can you reproduce the issue on https://psalm.dev ?

@imme-emosol
Copy link
Author

Screenshot is after scrolling up from https://psalm.dev/docs/running_psalm/configuration/#projectfiles .

@weirdan
Copy link
Collaborator

weirdan commented Jan 18, 2023

psalm.dev sources are available at https://github.com/psalm/psalm.dev

I believe it can be fixed in https://github.com/psalm/psalm.dev/blob/master/assets/sass/mkdocs_material_extra.scss, feel free to submit a PR to that repo.

@imme-emosol
Copy link
Author

Okay, thanks.

imme-emosol added a commit to imme-emosol/psalm.dev that referenced this issue Jan 18, 2023
Setting var `--md-typeset-color` to `initial` should make https://github.com/squidfunk/mkdocs-material/blob/6119df5d56fcdc90e25c5b1a47f7d2eba77f589e/src/assets/stylesheets/main/_typeset.scss#L43 use the color that was set by the user-agent/browser.

This does not seem like an ideal fix to me but it does fix a possible lack of contrast, as mentioned by me in: vimeo/psalm#9128 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants