IME input compatible #397
Closed
IME input compatible #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is as follows: The text input needs to be compatible with IME string input. Here's a brief overview of the problem: For languages like English, strings are directly input into the Input field. However, for some languages (such as Japanese and Chinese), input is done through an IME. The IME treats the input string as a buffer. Since this buffer passes the entire string being input each time the input event is called, the current process results in the string being displayed in duplicate. For example, when typing "ABC", the Input fires events for "A", "AB", "ABC". As a result, "AABABC" is entered on the screen (this example uses English characters for illustration purposes). This can be critical for countries that standardly use an IME. The correction is as follows: When IME input begins, a compositionstart event is called, and when it ends, a compositionend event is called. For IME inputs, since the Input event stores the entire string in the buffer, I've concatenated the pre-held string before input and the string being input, replacing everything accordingly. There might be a better method, but I believe replacing everything should not be particularly heavy processing.
|
I included your PR manually (wanted to ignore dist/* files). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues have been fixed.
I wrote the problem in an issues.
IME input compatible #396
I've made a correction regarding an issue that caught my attention, although JavaScript is not my specialty. However, from what I've tested with Japanese and English inputs, it seemed to work without any problems.
The correction is as follows:
When IME input begins, a compositionstart event is called, and when it ends, a compositionend event is called. For IME inputs, since the Input event stores the entire string in the buffer, I've concatenated the pre-held string before input and the string being input, replacing everything accordingly. There might be a better method, but I believe replacing everything should not be particularly heavy processing.