Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #192 - Isolate shadow from clipped layer #275

Merged
merged 4 commits into from
Nov 28, 2021
Merged

Issue #192 - Isolate shadow from clipped layer #275

merged 4 commits into from
Nov 28, 2021

Conversation

kmanaseryan
Copy link
Contributor

Related issue:

#192

Tasks

  • Create a separate function for rendering objects
  • Separate shadow effect from source-atop composition process
  • Keep the shadow in the original canvas
  • Draw the isolated canvas with composition but without shadow effect on top of the original canvas
  • Bonus: fix clipping mask not being applied on save

Demo:

https://www.loom.com/share/c31b4edde26f41058d54906087c815fb

@kmanaseryan
Copy link
Contributor Author

@viliusle please take a look

@viliusle viliusle merged commit d23b5e8 into viliusle:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmanaseryan @viliusle