Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle selection to make it work easier with text and smaller layers #207

Merged
merged 6 commits into from
Dec 5, 2020

Conversation

Giwayume
Copy link
Contributor

@Giwayume Giwayume commented Dec 3, 2020

image

image

  • Makes selection outline more visible against both dark and light colors
  • Selection outline increases in size when zooming out for visibility
  • Resize handles are on the outside of the selection by default so they don't interfere with layer editing
  • Handles move inside the layer when near the edge of canvas
  • Corner handles are always visible so it never becomes impossible to resize with mouse when very small

@viliusle viliusle added this to To DO in Main Dec 3, 2020
@viliusle viliusle moved this from To DO to In Progress in Main Dec 4, 2020
@viliusle
Copy link
Owner

viliusle commented Dec 4, 2020

I see multiple problems:

  • switch between outside and inside looks weird, inconsistent UI. Most image apps use selectors in middle and it looks less distracting.
  • rounded selectors looks much more better, even adobe XD use rounded, while MS paint and PS (i believe PS is old and outdated software, that should not be as example) use rectangles.

Sorry, but i don't want to accept this PR.

@Giwayume
Copy link
Contributor Author

Giwayume commented Dec 4, 2020

Most image apps use selectors in middle and it looks less distracting.

What are some examples? I'm trying to fix the problem with it covering up the corners of the layer. It's not just an issue with the text tool, I've had issues with image layers where I needed to see what's in the corner in order to to what I was doing.

rounded selectors looks much more better

This is more of a usability thing I'm trying to fix than a visual thing.

Here are some examples of corners being on the outside

Gimp
image

Godot (rounded)
image

The thing is, with these other software the selection works outside the bounds of the canvas so they don't have the issue of not being able to reach the handles on the edges. I'm trying to work around a limitation in miniPaint at the moment.

image

@Giwayume
Copy link
Contributor Author

Giwayume commented Dec 4, 2020

Adobe XD is a UI prototyping tool, not an image editor. It doesn't have a requirement to make the entire layer visible during editing, because it's more focused on image placement than image editing.

Adobe XD has the same problem with the handles cover the text, I'm not a fan of that
image

@Giwayume
Copy link
Contributor Author

Giwayume commented Dec 4, 2020

You like this better?

image

Only the handles that are at the edge of the canvas move inside

image

@Giwayume
Copy link
Contributor Author

Giwayume commented Dec 4, 2020

Another option with colored borders that's still visible when placed on top of the same color.

image
image

@viliusle viliusle merged commit 543124d into viliusle:master Dec 5, 2020
Main automation moved this from In Progress to Done Dec 5, 2020
@viliusle
Copy link
Owner

viliusle commented Dec 5, 2020

Your explanations makes sense.

I reverted "Alt color option", we will see how it looks and feels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Main
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants