Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/color improvements #181

Merged
merged 9 commits into from
Oct 22, 2020

Conversation

Giwayume
Copy link
Contributor

@Giwayume Giwayume commented Oct 22, 2020

#174

  • Added color swatches, so you can store the colors you've picked while working.
    • Future improvement: save them in the JSON file, and allow swapping them out as a set.
  • The color picker gradient square (I can't find an official name for this) can now be toggled to always display instead of in a popup.
    • Removed the spectrum library, since this was re-coded from scratch.
  • Each color channel (RGB), (HSV) now has a slider that shows a preview of what colors you're moving towards on either side of the spectrum.
  • These 3 sections can be toggled to display individually, this is saved in the cookie.
  • Renamed the color conversion functions in Helper class to have the same naming convention and return formats. This was all over the place.
  • New icons are pulled from Bootstrap https://icons.getbootstrap.com/

This is the new default for the color block. I figured this color picker is the most intuitive for most users, so it would make a good default. The buttons on the top right toggle the visibility of the swatches, picker, and color channel sliders.

Screenshot from 2020-10-22 02-04-25

This is how it looks with all sections toggled to be visible.

Screenshot from 2020-10-22 02-06-50

@viliusle
Copy link
Owner

viliusle commented Oct 22, 2020

Nice changes UX is really better.

Not very happy about so many new libs added, for example number-input component can be replaced by simple <iput type="number" />.

Also found issue where RGB inputs only shows max 2 numbers, even its 3 like 255, i will try to fix. (You use firefox i guess, good browser, sadly chrome takes all market.) - FIXED

@viliusle viliusle merged commit 324d94d into viliusle:master Oct 22, 2020
@Giwayume
Copy link
Contributor Author

@viliusle The reason I added number-input is:

  1. Custom styling, as native browser support for styling the up/down arrows is very limited.
  2. Future mobile support, my intent is to allow touch screen users to swipe up/down in the input to increase/decrease the value.

@Giwayume
Copy link
Contributor Author

Not very happy about so many new libs added

It's not libs, I wrote them all, also most of it is refactoring common code into separate files so they can be used in multiple places. For example, the range.js can replace <input type="range"> for more consistent styling across browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants