Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite menu from scratch to support mobile sized screens and keyboard controls #175

Merged
merged 8 commits into from
Oct 13, 2020

Conversation

Giwayume
Copy link
Contributor

I removed ddsmoothmenu and wrote a custom menu that tries its best to make sure that each menu dropdown stays on screen at all times.

  • config-menu.js has changed to a JSON definition that is easier to read and modify.
  • Menu dropdowns will open to the left if run out of space on the right. They might overlap if the screen is small enough.
  • Menu keyboard controls have been implemented based on WAI ARIA web standards. https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html
  • Please test to make sure everything is working as expected. I've covered all the use cases I'm aware of, but could have missed something.

Screenshot from 2020-10-12 01-18-56

@Giwayume
Copy link
Contributor Author

#167

@Giwayume Giwayume changed the title Rewrite menu from scratch to support mobile sized screens and keyboard controls WIP: Rewrite menu from scratch to support mobile sized screens and keyboard controls Oct 12, 2020
@Giwayume
Copy link
Contributor Author

Hold up, need to get the translations working again.

@Giwayume Giwayume changed the title WIP: Rewrite menu from scratch to support mobile sized screens and keyboard controls Rewrite menu from scratch to support mobile sized screens and keyboard controls Oct 12, 2020
@Giwayume
Copy link
Contributor Author

Translations should be good now.

@viliusle
Copy link
Owner

viliusle commented Oct 13, 2020

I like it, you can control it using keyboard, it is nice. Also few issues:

  • It does not work on IE11. I was supporting IE11 yesterday, but today - not sure if it is worth. It is time to forget this browser.
  • it is very hard to find and focus menu using keyboard only - FIXED.

Did you use any library for src/js/core/gui/gui-menu.js? If yes, let me know, i would add link for documentation.

@viliusle viliusle merged commit 57ed526 into viliusle:master Oct 13, 2020
@Giwayume
Copy link
Contributor Author

Giwayume commented Oct 13, 2020

I was supporting IE11 yesterday, but today - not sure if it is worth. It is time to forget this browser.

I agree. Even Microsoft Edge has moved to using Chromium as its rendering engine.

Did you use any library for src/js/core/gui/gui-menu.js?

No, I wrote the entire thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants