Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue with number inputs #53

Closed
Toad06 opened this issue Jun 12, 2017 · 3 comments
Closed

Minor issue with number inputs #53

Toad06 opened this issue Jun 12, 2017 · 3 comments

Comments

@Toad06
Copy link

Toad06 commented Jun 12, 2017

Hello,

Using the arrows of a number input will actually not change the relevant value. This seems to happen every time the "plus" and "minus" buttons are provided. For example, in the "Brush" tool, change the size with the arrows instead of the +/- buttons and notice the size actually remains to 10.

@viliusle
Copy link
Owner

viliusle commented Jun 12, 2017

I can not reproduce it. Which browser, which scenario? Using both buttons or keyboards works, but i found few related anomalies in code, maybe it will help (added more validation).

viliusle added a commit that referenced this issue Jun 12, 2017
@Toad06
Copy link
Author

Toad06 commented Jun 13, 2017

Both Firefox and Chrome. My explanations were not really clear, I have attached an image so it will be easier to see what I was talking about.

Adding this attribute to the input seems to fix it (only tested on Firefox):
oninput="GUI.update_attribute(this);"

brush

@viliusle
Copy link
Owner

another, final fix should be on 3.3.4 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants