Visiting index with Root Slash and Base normalizes URL in dev

[AleksandarFaraj]

Description

I am trying to create an index page with a vite base path.

// vite.config.ts
export default {
  base: "/local/"
}

Expected:

1. vite dev
2. http:https://localhost:3000/local/
3. Shows index page.

Actual:

1. vite dev
2. http:https://localhost:3000/local/
3. URL redirect: http:https://localhost:3000/local
4. Vite: 'did you mean /local/?'

[brillout]

AFAICT this is fine, but feel free to elaborate if you believe otherwise and I'll then re-open.

[AleksandarFaraj]

Well this is a huge pain because there is no way to actually open the index page when base is specified.

In essence; without this fix, vike does not support vite base.

[brillout]

You can set the base to /local instead, or wouldn't that work for you?

[AleksandarFaraj]

We have multiple product surfaces and we do not have it as a single spa. Using base /local breaks relative redirects.

Vite reference:
https://vitejs.dev/config/shared-options.html#base

[brillout]

I'm not sure I understand your point.

[AleksandarFaraj]

Sorry about that.

The base property for vite expects it to have a trailing slash. Specifically for our case we utilise relative links (not vike router or react router spa) when sending users from landing page (/) to auth (/auth) and app (/app). Those would break with base=/local because relative redirect to (app) from /local is /app not /local/app

https://vitejs.dev/config/shared-options.html#base
base
Type: string
Default: /
Base public path when served in development or production. Valid values include:

Absolute URL pathname, e.g. /foo/

[brillout]

The base property for vite expects it to have a trailing slash

That isn't true.

our case we utilise relative links (not vike router or react router spa) when sending users from landing page (/) to auth (/auth) and app (/app)

Is there a reason you don't use absolute links? In general, relative links are inherently broken in apps that have mutliple pages.

To be clear: I'm not saying Vike shouldn't support Base URLs with a trailing slash, but it doesn't seem high priority either.

[brillout]

Thanks for the feedback; you were right with the relative paths being bad and I improved our code to not depend on relative URLs.

👍

But I ran into another parity issue, storybook utilises base ./ which vike doesn't support

Relative Base URLs also don't make much sense for multi-page apps, see #606.

[brillout]

Reproduction: https://github.com/brillout/vike-reprod-1258.

[brillout]

support Base URLs with a trailing slash

Fixed and pre-released as 0.4.146-commit-701e2e5.

---

@AleksandarFaraj Btw. would your company be up for sponsoring?