Chore: introduces core ES module. #6287
Merged
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Nov 12, 2019
gkatsev
approved these changes
Nov 14, 2019
misteroneill
approved these changes
Nov 15, 2019
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces an alternative ES module file for videojs core build.
I created this PR because I would like to use videojs core directly from the browser like this:
<script type="module"> import videojs from 'video.js/dist/alt/video.core.es.js'; </script>For now, main videojs build supports umd, cjs and es module. Not sure why core build supports only cjs and umd.
Requirements Checklist