fix: make sure sources, volume, and playback rate are reset along with the player #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
commented
Dec 12, 2018
test/unit/player.test.js
Outdated
| assert.deepEqual(player.currentSource(), {}, 'currentSource is correct'); | ||
| assert.deepEqual(player.currentSources(), [], 'currentSources is correct'); | ||
| assert.strictEqual(player.playbackRate(), 1, 'playbackRate is correct'); | ||
| assert.strictEqual(player.volume(), 0, 'volume is correct'); |
There was a problem hiding this comment.
This is 0 because of TechFaker's default.
| resetCache_() { | ||
| this.cache_ = { | ||
| lastVolume: 1, | ||
| lastPlaybackRate: this.defaultPlaybackRate(), |
There was a problem hiding this comment.
Should we set currentTime, duration, selectedLanguage to null/empty string here too?
There was a problem hiding this comment.
I left those out because it appeared they got set in their getter/setters, but it probably makes sense to set a default for everything here.
There was a problem hiding this comment.
Turns out setting selectedLanguage in here has all kinds of side effects. Probably best left to another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5675
This PR will fully clear the
player.cache_when callingPlayer#reset.Requirements Checklist