Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change code example transmuxer event listeners #438

Merged

Conversation

arturparkhisenko
Copy link
Contributor

@arturparkhisenko arturparkhisenko commented Oct 3, 2023

Resolves #407 and #323
Context is in 407.

A mini contribution for https://hacktoberfest.com/ if you'll be kind to add the label hacktoberfest-accepted for this PR. Thanks!

@arturparkhisenko
Copy link
Contributor Author

@alex-barstow thought to ask for your review if you'll have a moment. Thanks

@arturparkhisenko
Copy link
Contributor Author

arturparkhisenko commented Oct 14, 2023

cc @wseymour15 , based on recent activity ;) or should we invite @misteroneill or @adrums86?

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this!

Copy link
Contributor

@wseymour15 wseymour15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing! It would be nice if there was an event listener called one on the transmuxer which just handled a single event and then disposed of the listener, but since that currently does not exist, I think this is a fine solution!

@arturparkhisenko
Copy link
Contributor Author

How we can merge it to wrap it up? :) cc @dzianis-dashkevich if you can help us here.

@dzianis-dashkevich dzianis-dashkevich merged commit 2d61f49 into videojs:main Mar 7, 2024
2 checks passed
@dzianis-dashkevich
Copy link
Contributor

@arturparkhisenko merged! Thank you for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample code: It does not work.
4 participants