Align quantity group columns horizontally #898
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetrell
changed the title
jpetrell
commented
Mar 26, 2024
| VeQuickItem { | ||
| id: nrOfModulesOffline | ||
| uid: root.bindPrefix + "/System/NrOfModulesOffline" | ||
| }, |
There was a problem hiding this comment.
Unused and duplicated (see modulesOnline and modulesOffline VeQuickItems above).
- Calm down the stutter that happens when values get updated - Calm down the static layout by forcing alignment - Don't apply everywhere, e.g. the status text columns are a lot wider than the quantity labels - This became a bit complex so not sure if the benefit is justified Fixes #863.
jpetrell
force-pushed
the
jpetrell/align-quantity-groups
branch
from
a9397a0
to
021cf91
Compare
|
Discussed with Bea and Serg that while the current layout is suboptimal, maybe not worth it to integrate the improvement to 1.0 now, but visit this during the settings redesign work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this would be quick thing to do between bigger tasks (with quantity table alignments still fresh on my memory), but this became a bit complex due to different ways the quantity and text groups are used. Also, this may end up being a stopgap solution as the upcoming settings redesign likely introduces various design changes to these settings list items.
Requires more testing and some performance profiling before merging. The quantity repeater is constantly recreating all the quantity labels when the value update, which also causes a lot of unnecessary relayout calculations.