Only show the red 'Silence alarm' button when alarms are active #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriadam
reviewed
Jul 11, 2024
pages/NotificationsPage.qml
Outdated
| text: qsTrId("silence_alarm") | ||
| text: Global.notifications.alarm | ||
| //% "Silence alarm" | ||
| ? qsTrId("silence_alarm") |
There was a problem hiding this comment.
I'd prefer a more unique translation id, something like: "notifications_silence_alarm"
Previously, we showed the red 'Silence alarm' button when an alert was active. Now, we shoe an orange 'Acknowledge alerts' button if only alerts are active, or a red 'Silence alarm' button if an alarm is active. Fixes #1297
DanielMcInnes
force-pushed
the
1297-silence-alarms-button-on-notificationspage-is-showing-under-wrong-conditions
branch
from
cc0884d
to
6b1dc7a
Compare
chriadam
approved these changes
Jul 11, 2024
DanielMcInnes
deleted the
1297-silence-alarms-button-on-notificationspage-is-showing-under-wrong-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we showed the red 'Silence alarm' button when an alert was active. Now, we shoe an orange 'Acknowledge alerts' button if only alerts are active, or a red 'Silence alarm' button if an alarm is active.
Fixes #1297