Solar quantity table summary #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must handle the case where dailyHistory() returns a null object, otherwise acccessing yieldKwh on the null object results in an undefined access error. This fixes it to use NaN if dailyHistory() returns null. Fixes #1280
blammit
commented
Jun 30, 2024
| @@ -30,7 +30,7 @@ Page { | |||
| }, | |||
| { | |||
| title: CommonWords.yield_today, | |||
| value: root.solarCharger.dailyHistory(0).yieldKwh || 0, | |||
| value: solarCharger.dailyHistory(0)?.yieldKwh ?? NaN, | |||
There was a problem hiding this comment.
Note, this is equivalent to:
const history = solarCharger.dailyHistory(0)
return history ? history.yieldKwh : NaN
The syntax takes some getting used to, but it'd be nice to get rid of the "if null return NaN" repetitive pattern throughout the codebase.
See https://en.wikipedia.org/wiki/Null_coalescing_operator and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining.
DanielMcInnes
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.