[GEOT-6833] Add missing @OverRide annotations to modules/unsupported/*

vickdw · Mar 8, 2021 · 8901b6f · 8901b6f
1 parent f397555
commit 8901b6f
Show file tree

Hide file tree

Showing 180 changed files with 839 additions and 0 deletions.
diff --git a/...nsupported/css/src/main/java/org/geotools/styling/css/CachedSimplifyingFilterVisitor.java b/...nsupported/css/src/main/java/org/geotools/styling/css/CachedSimplifyingFilterVisitor.java
@@ -77,6 +77,7 @@ public Object visit(Not filter, Object extraData) {
  return result;
  }
 
+ @Override
  protected List<Filter> extraAndSimplification(Object extraData, List<Filter> filters) {
  if (filters.size() > 1) {
  // if there are nested ors and top level filters, try factoring out common expression,
@@ -153,6 +154,7 @@ protected List<Filter> extraAndSimplification(Object extraData, List<Filter> fil
  return filters;
  }
 
+ @Override
  protected List<Filter> extraOrSimplification(Object extraData, List<Filter> filters) {
  if (filters.size() > 1) {
  // if there are nested ands and top level filters, try factoring out common expression,

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/Value.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/Value.java
@@ -254,6 +254,7 @@ public boolean equals(Object obj) {
  return true;
  }
 
+ @Override
  public org.opengis.filter.expression.Expression toExpression() {
  Matcher matcher = PERCENTAGE.matcher(body);
  if (matcher.matches()) {
@@ -264,6 +265,7 @@ public org.opengis.filter.expression.Expression toExpression() {
  return FF.literal(body);
  }
 
+ @Override
  public String toLiteral() {
  return body;
  }
@@ -543,10 +545,12 @@ public String toString() {
  return "Expression [expression=" + expression + "]";
  }
 
+ @Override
  public org.opengis.filter.expression.Expression toExpression() {
  return expression;
  }
 
+ @Override
  public String toLiteral() {
  throw new UnsupportedOperationException(
  "Cannot turn this value into a literal: " + this);

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Accept.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Accept.java
@@ -30,6 +30,7 @@ public Specificity getSpecificity() {
  return Specificity.ZERO;
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/And.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/And.java
@@ -43,6 +43,7 @@ public String toString() {
  return "And [children=" + getChildren() + "]";
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Data.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Data.java
@@ -110,6 +110,7 @@ public Specificity getSpecificity() {
  return new Specificity(0, extractor.getSpecificityScore(), 0);
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Id.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Id.java
@@ -79,6 +79,7 @@ public Specificity getSpecificity() {
  }
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Or.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Or.java
@@ -41,6 +41,7 @@ public Specificity getSpecificity() {
  return max;
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/PseudoClass.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/PseudoClass.java
@@ -30,6 +30,7 @@ public static Selector combineAnd(List<PseudoClass> selectors, Object ctx) {
 
  public static final PseudoClass ROOT =
  new PseudoClass(null, -1) {
+ @Override
  public String toString() {
  return "ROOT";
  };
@@ -96,6 +97,7 @@ public Specificity getSpecificity() {
  }
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Reject.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/Reject.java
@@ -30,6 +30,7 @@ public Specificity getSpecificity() {
  return Specificity.ZERO;
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/ScaleRange.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/ScaleRange.java
@@ -79,6 +79,7 @@ public String toString() {
  return "ScaleRange " + range;
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/TypeName.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/selector/TypeName.java
@@ -72,6 +72,7 @@ public Specificity getSpecificity() {
  return Specificity.ELEMENT_1;
  }
 
+ @Override
  public Object accept(SelectorVisitor visitor) {
  return visitor.visit(this);
  }

diff --git a/...supported/css/src/main/java/org/geotools/styling/css/util/FilterSpecificityExtractor.java b/...supported/css/src/main/java/org/geotools/styling/css/util/FilterSpecificityExtractor.java
@@ -35,11 +35,13 @@ public class FilterSpecificityExtractor extends DefaultFilterVisitor {
 
  Set<Expression> properties = new HashSet<>();
 
+ @Override
  public Object visit(PropertyName expression, Object data) {
  properties.add(expression);
  return data;
  }
 
+ @Override
  public Object visit(org.opengis.filter.expression.Function expression, Object data) {
  super.visit(expression, data);
  if (expression instanceof VolatileFunction) {

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/util/FilterTypeVisitor.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/util/FilterTypeVisitor.java
@@ -152,71 +152,85 @@ public Object visit(Function expression, Object data) {
  return super.visit(expression, data);
  }
 
+ @Override
  public Object visit(After after, Object data) {
  visitTemporalExpression(after);
  return super.visit(after, data);
  }
 
+ @Override
  public Object visit(AnyInteracts anyInteracts, Object data) {
  visitTemporalExpression(anyInteracts);
  return super.visit(anyInteracts, data);
  }
 
+ @Override
  public Object visit(Before before, Object data) {
  visitTemporalExpression(before);
  return super.visit(before, data);
  }
 
+ @Override
  public Object visit(Begins begins, Object data) {
  visitTemporalExpression(begins);
  return super.visit(begins, data);
  }
 
+ @Override
  public Object visit(BegunBy begunBy, Object data) {
  visitTemporalExpression(begunBy);
  return super.visit(begunBy, data);
  }
 
+ @Override
  public Object visit(During during, Object data) {
  visitTemporalExpression(during);
  return super.visit(during, data);
  }
 
+ @Override
  public Object visit(EndedBy endedBy, Object data) {
  visitTemporalExpression(endedBy);
  return super.visit(endedBy, data);
  }
 
+ @Override
  public Object visit(Ends ends, Object data) {
  visitTemporalExpression(ends);
  return super.visit(ends, data);
  }
 
+ @Override
  public Object visit(Meets meets, Object data) {
  visitTemporalExpression(meets);
  return super.visit(meets, data);
  }
 
+ @Override
  public Object visit(MetBy metBy, Object data) {
  visitTemporalExpression(metBy);
  return super.visit(metBy, data);
  }
 
+ @Override
  public Object visit(OverlappedBy overlappedBy, Object data) {
  visitTemporalExpression(overlappedBy);
  return super.visit(overlappedBy, data);
  }
 
+ @Override
  public Object visit(TContains contains, Object data) {
  visitTemporalExpression(contains);
  return super.visit(contains, data);
  }
 
+ @Override
  public Object visit(TEquals equals, Object data) {
  visitTemporalExpression(equals);
  return super.visit(equals, data);
  }
 
+ @Override
  public Object visit(TOverlaps contains, Object data) {
  visitTemporalExpression(contains);
  return super.visit(contains, data);
@@ -233,6 +247,7 @@ private void visitTemporalExpression(BinaryTemporalOperator expression) {
  }
  }
 
+ @Override
  public Object visit(PropertyIsBetween filter, Object data) {
  String name = getPropertyName(filter.getExpression());
  if (name != null) {
@@ -248,31 +263,37 @@ public Object visit(PropertyIsBetween filter, Object data) {
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsEqualTo filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsNotEqualTo filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsGreaterThan filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsGreaterThanOrEqualTo filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsLessThan filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(PropertyIsLessThanOrEqualTo filter, Object data) {
  visitBinaryComparison(filter);
  return super.visit(filter, data);
@@ -295,6 +316,7 @@ private void visitBinaryComparison(BinaryComparisonOperator filter) {
  }
  }
 
+ @Override
  public Object visit(PropertyIsLike filter, Object data) {
  String name = getPropertyName(filter.getExpression());
  if (name != null) {
@@ -303,51 +325,61 @@ public Object visit(PropertyIsLike filter, Object data) {
  return null;
  }
 
+ @Override
  public Object visit(Beyond filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Contains filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Crosses filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Disjoint filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(DWithin filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Equals filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Intersects filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Overlaps filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Touches filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);
  }
 
+ @Override
  public Object visit(Within filter, Object data) {
  visitBinarySpatialOperator(filter);
  return super.visit(filter, data);

diff --git a/modules/unsupported/css/src/main/java/org/geotools/styling/css/util/Signature.java b/modules/unsupported/css/src/main/java/org/geotools/styling/css/util/Signature.java
@@ -43,6 +43,7 @@ public abstract class Signature implements Cloneable {
  public abstract int size();
 
  /** Clones the signature */
+ @Override
  public abstract Object clone();
 
  @Override
@@ -83,6 +84,7 @@ public BitsetSignature(BitsetSignature other) {
  this.size = other.size;
  }
 
+ @Override
  public void increment() {
  for (int i = 0; i < bs.size(); i++) {
  if (bs.get(i)) {
@@ -94,6 +96,7 @@ public void increment() {
  }
  }
 
+ @Override
  public boolean contains(Signature otherSignature, int k) {
  BitsetSignature other = (BitsetSignature) otherSignature;
  final int max = Math.min(bs.size(), k + 1);
@@ -125,6 +128,7 @@ public int size() {
  return size;
  }
 
+ @Override
  public Object clone() {
  return new BitsetSignature(this);
  }

diff --git a/...rted/elasticsearch/src/main/java/org/geotools/data/elasticsearch/ElasticCapabilities.java b/...rted/elasticsearch/src/main/java/org/geotools/data/elasticsearch/ElasticCapabilities.java
@@ -167,14 +167,17 @@ private class ElasticIsFullySupportedFilterVisitor extends IsFullySupportedFilte
  super(getContents());
  }
 
+ @Override
  public Object visit(ExcludeFilter filter, Object extraData) {
  return true;
  }
 
+ @Override
  public Object visit(IncludeFilter filter, Object extraData) {
  return true;
  }
 
+ @Override
  public Object visit(BegunBy begunBy, Object extraData) {
  return visit((BinaryTemporalOperator) begunBy, BegunBy.NAME);
  }

diff --git a/...ted/elasticsearch/src/main/java/org/geotools/data/elasticsearch/ElasticFeatureSource.java b/...ted/elasticsearch/src/main/java/org/geotools/data/elasticsearch/ElasticFeatureSource.java
@@ -61,6 +61,7 @@ public ElasticFeatureSource(ContentEntry entry, Query query) throws IOException
  }
 
  /** Access parent datastore */
+ @Override
  public ElasticDataStore getDataStore() {
  return (ElasticDataStore) super.getDataStore();
  }