Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organise modifiers on Quantum tab #131

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Conversation

bgkendall
Copy link
Contributor

There are now three layouts for modifiers on the “Quantum” tab that are selected as the window width decreases, wide, narrow and “none”:

  • The wide format is laid out with the following rows:
    • Grave/Escape and the “L/RShift_T(parens)” keys
    • One-Shot Modifiers, grouped by left modifiers, right modifiers, combinations
    • Modifier + Keys, grouped as One-Shot Modifiers and in (almost) the same order (with some gaps where a One-Shot is defined, but an equivalent Mod+ is not)
    • Mod-Taps, grouped as Mod+ keys
  • The narrow format is laid out with the following rows:
    • Grave/Escape and the “L/RShift_T(parens)” keys
    • One-Shot modifiers, grouped by left modifiers, some combinations
    • One-Shot modifiers, grouped by right modifiers, other combinations
    • Modifier + Keys, grouped by left modifiers, some combinations
    • Modifier + Keys, grouped by right modifiers, other combinations
    • Mod-Taps, grouped by left modifiers, some combinations
    • Mod-Taps, grouped by right modifiers, some combinations
  • The “none” format is the same as before with the keys just displayed one after the other as listed in keycodes.py

The two new layouts make it much easier to find the desired modifier key. Instead of having to scan through the list of keys, the keys are now organised by function (rows) and modifier (column).

The reset, “magic”, etc. keys follow the modifiers in a sequential block as before.

Wide Layout

Wide Layout

Narrow Layout

Narrow Layout

No Layout

No Layout

 * Only attempt to organise modifier keys. All others will appear in the same order as before after the formatted modifiers.
 * Add narrower layout for organised modifiers.
 * Renamed `KEYCODES_RESET` to `KEYCODES_BOOT` since `RESET` will become `QK_BOOT` in the near future.
 * Reordered includes to minimise changes in pull request.
 * Remover spurious `"`
@xyzz xyzz merged commit 2629b4e into vial-kb:main Sep 5, 2022
@bgkendall bgkendall deleted the organise-modifiers branch September 6, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants