Return code rework #391
Merged
Return code rework #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so make ::pwrite return an int
instead of throwing an exception, as with writeOneBlock
instead of throwing an exception, as with read/write
Closed
benrubson
reviewed
Aug 26, 2017
encfs/RawFileIO.cpp
Outdated
| // never know... | ||
| return -eno; | ||
| } | ||
| if (writeSize == 0) { | ||
| return -EIO; | ||
| } |
There was a problem hiding this comment.
Here we return EIO we loose a chance to return correct errno : depending on implementations pwrite could set errno when it returns 0.
This is why I tested if (writeSize <= 0) in my initial commit.
Could we then get back to previous version here ?
Many thanks 👍
encfs/RawFileIO.cpp
Outdated
| @@ -206,8 +209,6 @@ ssize_t RawFileIO::read(const IORequest &req) const { | |||
|
|
|||
| if (readSize < 0) { | |||
| int eno = errno; | |||
| errno = 0; // just to be sure error seen in integration tests really comes | |||
| // from the function rc. | |||
There was a problem hiding this comment.
I would have been pleased to keep this, as explained in the comment just to be sure...
Thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #380, eliminates mutation of errno, fixes formatting and fixes clang-tidy warnings.