Revert "-S" ABI change #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change intended to fix a segfault when encfs is passed a zero-length password (#241). However, it also changed the CLI ABI which caused breakage in Cryptkeeper (tomm/cryptkeeper#23) and other third-party projects that call EncFS. Fixes #280 . This reverts commit c3a7da5.
The requirement that the password is not empty was not enforced properly in all getUserKey() variants. Add the check to makeKey() instead that is called in every code path. This also fixes the crash desribed at #241 .
|
@vgough I will merge this tomorrow unless you object |
|
Does it make sense to consider requiring the password length to be greater than 1? Or is that just a pointless, compatibility-breaking change? |
|
@jrchamp I'm already afraid that enforcing non-empty passwords will cause some complaints, I'd rather not take this further ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert c3a7da5 and enforce empty password ban.
Context: tomm/cryptkeeper#23 #280