fixed multiple issues with expression checking #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalance
reviewed
Jun 13, 2024
| )); | ||
| self.errors.push(error); | ||
| } else { | ||
| self.call_stack_kind.push(FunctionKind::NonSystem); |
There was a problem hiding this comment.
I think self.call_stack_kind.pop corresponding to this push may be required at HandlerPoint::After.
dalance
reviewed
Jun 14, 2024
| self.call_stack_kind.pop(); | ||
| } | ||
| SymbolKind::SystemFunction => { | ||
| self.call_stack_kind.push(FunctionKind::System); |
There was a problem hiding this comment.
Why is this push not pop?
|
Because I'm an idiot
…On Thu, Jun 13, 2024, 7:37 PM Naoya Hatta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In crates/analyzer/src/handlers/check_expression.rs
<https://urldefense.com/v3/__https://github.com/veryl-lang/veryl/pull/786*discussion_r1639076813__;Iw!!DZ3fjg!5qGyUMlwQqJ6XqiXcahwa8-yUJqqGw2eoFen36hUvMMb7rN82H7L6S2HFdODARSfKAA5DGWAzcJnqyHKu35epSl6N5Uu$>
:
> @@ -93,6 +125,19 @@ impl<'a> VerylGrammarTrait for CheckExpression<'a> {
}
}
}
+ } else if let Factor::ExpressionIdentifierFactorOpt(x) = arg {
+ let expid = x.expression_identifier.as_ref();
+ if let Ok(rr) = symbol_table::resolve(expid) {
+ match rr.found.kind {
+ SymbolKind::Function(_) | SymbolKind::ModportFunctionMember(_) => {
+ self.call_stack_kind.pop();
+ }
+ SymbolKind::SystemFunction => {
+ self.call_stack_kind.push(FunctionKind::System);
Why is this push not pop?
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/veryl-lang/veryl/pull/786*pullrequestreview-2117224001__;Iw!!DZ3fjg!5qGyUMlwQqJ6XqiXcahwa8-yUJqqGw2eoFen36hUvMMb7rN82H7L6S2HFdODARSfKAA5DGWAzcJnqyHKu35epcaKsQjW$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFAMUBAPKSS3B6CIDF4SDR3ZHI3MHAVCNFSM6AAAAABJG3T4YCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGIZDIMBQGE__;!!DZ3fjg!5qGyUMlwQqJ6XqiXcahwa8-yUJqqGw2eoFen36hUvMMb7rN82H7L6S2HFdODARSfKAA5DGWAzcJnqyHKu35epVeZvQWe$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised by @nananapo in #785 but also fixes a number of other related issues.
Enum,Union,Struct,UnionMember, andStructMemberare suitable to be passed into functions with KindSystemFunction.