Fix a race condition in SimulcastConsumer #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race happens when `SimulcastConsumer` is about to switch spatial layers and receives a key-frame for a spatial layer it doesn't expect after setting flag `syncRequired` true.
|
Can you please connect the associated issue you reported so it will be auto-closed once this PR is merged? |
Done |
Looks good to mee too 👍. Good catch @dsdolzhenko. I've made a little comment. Other than that 👍 |
jmillan
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race happens when
SimulcastConsumeris about to switch spatial layers and receives a key-frame for a spatial layer it doesn't expect after setting flagsyncRequiredtrue.It's a fix for #824