Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at fixing navigator.mediaDevices #862

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjkundert
Copy link

@pjkundert pjkundert commented Jun 21, 2024

First pass; chatty and probably wrong...

  • Why didn't the final .catch do anything, and what is the right thing to do? Just log and re-raise the Error, and let the chips fall where they may? This is an un-recoverable error, since the caller must invoke the code from a secure context like https:// or file:https:///, so there's nothing we can do in the code to fix the situation. Might as well blow it up...
  • The this._failed calls seem to blow up the SIP call, making the subsequent this.emit('getusermediafailed', error); signal sort of pointless; is the order wrong? Seems to be done in differing orders, elsewhere...

I'm not a Javascript expert, so probably other stuff, too.

fixes: #861

@pjkundert
Copy link
Author

I have a demo that can serve up a simple JsSIP interface via a crude https session w/ self-signed certificates:

https://github.com/pjkundert/jsSip-demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant