Add new max_last_will_delay value and change default
#1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larshesel can this be merged or does it need to wait for a specific release? |
|
I've postponed merging minor features as this makes it much easier to create bugfix releases. This will likely be merged either this or next week. |
The current default of `0s` was confusing to the users and as long as it is possible from the broker side to limit this then it makes sense for the default to be what the client provides. This can now be done by specifying `client` instead of a time value. Add @wlisac to the THANKS file
larshesel
force-pushed
the
change-will-delay-default
branch
from
f292a62
to
3a3e060
Compare
|
@wlisac merged! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default of
0swas confusing to the users and as long asit is possible from the broker side to limit this then it makes sense
for the default to be what the client provides. This can now be done
by specifying
clientinstead of a time value.