Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix entry point for storybook, add storybook static ouput to gitignore #67207

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: fix entry point for storybook, add storybook static ouput to gitignore #67207

merged 1 commit into from
Jun 26, 2024

Conversation

crebelskydico
Copy link
Contributor

This PR will fix #67206

  • contributing guidelines for examples are followed
  • lint runs without errors

@ijjk ijjk added the examples Issue/PR related to examples label Jun 26, 2024
@ijjk
Copy link
Member

ijjk commented Jun 26, 2024 •
edited by eps1lon
Loading

Allow CI Workflow Run

  • approve CI run for commit: d48e9ef

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

eps1lon
eps1lon approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@devjiwonchoi devjiwonchoi merged commit b9ffa84 into vercel:canary Jun 26, 2024
33 checks passed
@devjiwonchoi
Copy link
Member

Thank you for the PR!

@crebelskydico crebelskydico deleted the with-storybook-example-entry-fix branch June 26, 2024 13:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@devjiwonchoi devjiwonchoi devjiwonchoi approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix storybook entry point for with-storybook example
4 participants
@crebelskydico @ijjk @devjiwonchoi @eps1lon