Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with-sitemap example for App Router #66995

Merged
merged 13 commits into from
Jun 20, 2024

Conversation

archanaagivale30
Copy link
Contributor

Hello

This PR updates the with-sitemap example to use:

  1. App Router
  2. TypeScript
  3. sitemap.js

@archanaagivale30 archanaagivale30 requested review from a team as code owners June 18, 2024 14:45
@archanaagivale30 archanaagivale30 requested review from manovotny and leerob and removed request for a team June 18, 2024 14:45
@ijjk ijjk added the examples Issue/PR related to examples label Jun 18, 2024
@ijjk
Copy link
Member

ijjk commented Jun 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: e960b6c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx
Copy link
Member

samcx commented Jun 19, 2024

@archanaagivale30 Hi there, one thing we should change is not using output: export.

@archanaagivale30
Copy link
Contributor Author

@archanaagivale30 Hi there, one thing we should change is not using output: export.

Hi @samcx,
I was considering the SSG scenario but I removed output: export from the config file in the latest commit.
Thanks for your feedback!

@samcx
Copy link
Member

samcx commented Jun 19, 2024

@archanaagivale30 No need to merge canary—everything time you do, I have to override (or merge canary myself) so we successfully run the CI.

@archanaagivale30
Copy link
Contributor Author

@samcx understood I will take care of this with future changes.

@samcx
Copy link
Member

samcx commented Jun 20, 2024

@archanaagivale30 Are you positive this file gets created on the development server inside a /public (not seeing this)?

@archanaagivale30
Copy link
Contributor Author

@samcx It will not create sitemap.xml file in /public folder as per documentation of App Router its implemented. It will create automatically on server side application and will accessible on route '/sitemap.xml'. And for Static site it will generate in out directory.

examples/with-sitemap/README.md Outdated Show resolved Hide resolved
@samcx samcx enabled auto-merge (squash) June 20, 2024 08:46
@samcx samcx merged commit b5f97ca into vercel:canary Jun 20, 2024
34 checks passed
@github-actions github-actions bot added the locked label Jul 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants