fix: Prevent MongoDB client promise being cached #66977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More context in this bug report: https://jira.mongodb.org/browse/NODE-6179 Solution taken from this commit: mongodb-developer/nextjs-with-mongodb@c08bc96
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
This change also needs to be applied to vercel/mongodb-starter. Although there may be an issue due to Auth.js (or NextAuth in this case) where More context in this work in progress commit. |
|
Also, if there is a more appropriate comment to add here please feel free to adjust. I removed it as I was unsure whether its still possible to use another database in a similar way. |
timneutkens
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update to examples/with-mongodb to incorporate fix from the MongoDB team. This should prevent intermittent serverless function timeouts due to cached promise.
Why?
Vercel users reported intermittent 500 errors when connecting to their MongoDB Atlas clusters in production environments.
Full bug report: NODE-6179
Related issues:
How?
Solution by @baileympearson – thank you 🖤
View commit in
mongodb-developer/nextjs-with-mongodbpnpm build && pnpm lint. See linting docs.