Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add Lingui to the Internationalization Page #66953

Merged

Conversation

andrii-bodnar
Copy link
Contributor

What?

This PR adds Lingui to the list of i18n resources on the Internationalization page for the App Router.

Why?

Recently, Lingui got some great improvements regarding RSC support. We also have a new separate article Lingui with React Server Components and sample projects that show how to use Lingui for i18n in Next.js project with App Router (by @vonovak).

So I think it would be great to add Lingui to this list.

How?

Add a new list item.

@andrii-bodnar andrii-bodnar requested review from a team as code owners June 17, 2024 09:34
@andrii-bodnar andrii-bodnar requested review from ismaelrumzan and molebox and removed request for a team June 17, 2024 09:34
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 17, 2024
@ijjk
Copy link
Member

ijjk commented Jun 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: 65fe46c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jun 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: 65fe46c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit aa54867 into vercel:canary Jun 17, 2024
32 checks passed
@andrii-bodnar andrii-bodnar deleted the chore/add-lingui-to-app-router-docs branch June 17, 2024 17:08
@github-actions github-actions bot added the locked label Jul 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants