Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-flake next-image test #66882

Merged
merged 2 commits into from
Jun 14, 2024
Merged

de-flake next-image test #66882

merged 2 commits into from
Jun 14, 2024

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jun 14, 2024

This navigation event is timing out in Turbopack builds, but not for any particularly good reason: I think the link click is just taking a while, due to builds still being fairly experimental.

Rather than clicking a link to navigate to the client side test suite, this just starts the test there, which is similar to how the server test works anyway and still accomplishes what this test is intended for.

Flakes:
1
2
3
4

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team tests labels Jun 14, 2024
Copy link
Member Author

ztanner commented Jun 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Jun 14, 2024

Tests Passed

@ztanner ztanner marked this pull request as ready for review June 14, 2024 19:33
@ztanner ztanner requested review from ismaelrumzan and leerob and removed request for a team June 14, 2024 19:33
@ztanner ztanner merged commit 6ae9828 into canary Jun 14, 2024
78 of 79 checks passed
@ztanner ztanner deleted the 06-14-de-flake_next-image_test branch June 14, 2024 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants