Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookies.mdx to show that maxAge accepts a value in seconds #66476

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

anay-208
Copy link

@anay-208 anay-208 commented Jun 2, 2024

In the discord server, people were confused whether maxAge accepts in second or millisecond. It would be worth specifying it

In the discord server, people were confused whether maxAge accepts in second or millisecond. It would be worth specifying it
@anay-208 anay-208 requested review from a team as code owners June 2, 2024 20:52
@anay-208 anay-208 requested review from manovotny and delbaoliveira and removed request for a team June 2, 2024 20:52
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 2, 2024
@ijjk
Copy link
Member

ijjk commented Jun 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: effd2eb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jun 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: effd2eb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) June 2, 2024 23:32
@samcx samcx merged commit 128e80c into vercel:canary Jun 2, 2024
33 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants