docs: remove invalid og image cases #66355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
requested review from
timneutkens,
ijjk,
shuding,
styfle,
ztanner and
a team
as code owners
huozhi
requested review from
timeyoutakeit and
leerob
and removed request for
a team
ijjk
added
created-by: Next.js team
ijjk
approved these changes
May 29, 2024
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removing the
/[...catchall]/<metadata image convention>.jscase from docsWhy
Since og image and icon routes are using catch-all routes to handle the both single or multiple routes. For instance:
app/opengraph-image.jscan possibly generate two cases:/opengraph-imagegenerateImageMetadata():/opengraph-image/[id]We're not able to detect if there's
generateImageMetadatadefined in the file before mapping the routes, and decided to create the different routes to either/opengraph-imageor/opengraph-image/[id]. That's why we're using a catch-all routes to handle them rn.Related #48106
Related #57349