fix(examples/with-react-intl): Bug when accept-language is not 'en' #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther then 'en' package accept returns false if can't find language in offered list of languages, then later on bool is attempted to be split, and app crashes in prod & dev
|
Makes sense 👍 |
|
Thanks! @timneutkens |
|
@ultrox @timneutkens My default locale is en, and now I'm getting the locale.split is not a function error, even with this fix. accept.language(languages) // is returning['en-GB', 'en']
getLocaleDataScript(locale) // then this function calls split on an array
|
rauchg
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Fix for locale.split is not a function. Following from #5488 - Renamed languages to supportedLanguages - Firstly, accept languages based on supportedLanguages - And finally, accept a single language, if it returns false, the default of 'en' is used. I looked at the navigator library, which is used by 'accept', this should be a more solid solution, since we can now know that `const locale` is always a string. // Before (Sometimes returns an array as `const local`) const locale = accept.language(languages) || 'en' // After (Always returns a string) const locale = accept.language(accept.languages(supportedLanguages)) || 'en'; * Update server.js Update variable name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behaviour
When you run
npm run devand visit the http:https://localhost:3000 with browser with locale other then 'en' in development you should be served eng version of the app.Also expected in dev in console per explanation in readme ( & after fix is applyed)
Actual Behaviour
When you visit app in dev mode & in production, app crashes
Reason
package 'accept' returns false if can't find language in offered list of languages, then later on
bool is attempted to be split, and app crashes in prod & dev.