Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change README structure in examples #35349

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Change README structure in examples #35349

merged 6 commits into from
Mar 16, 2022

Conversation

Nutlope
Copy link
Contributor

@Nutlope Nutlope commented Mar 16, 2022 •
edited
Loading

Changed the README structure in all examples to take out the Stackblitz button and include it as a link instead using a bash script.

I also added the Vercel deploy button to 15 READMEs that didn't have it.

@ijjk ijjk added the examples Issue/PR related to examples label Mar 16, 2022
balazsorban44
balazsorban44 previously approved these changes Mar 16, 2022
View reviewed changes
leerob
leerob previously approved these changes Mar 16, 2022
View reviewed changes
ijjk
ijjk requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as it seems we accidentally deleted a few readmes un-expectedly here, if this was on purpose feel free to dismiss this.

@Nutlope Nutlope dismissed stale reviews from leerob and balazsorban44 via e213684 March 16, 2022 18:21
@Nutlope Nutlope requested review from ijjk and leerob March 16, 2022 18:22
@kodiakhq kodiakhq bot merged commit 33aa51a into canary Mar 16, 2022
@kodiakhq kodiakhq bot deleted the update-examples-readmes branch March 16, 2022 21:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob approved these changes

@balazsorban44 balazsorban44 balazsorban44 left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nutlope @leerob @balazsorban44 @ijjk