Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ESM-CJS interoperable import in find-config #34451

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

ctjlewis
Copy link
Contributor

@ctjlewis ctjlewis commented Feb 16, 2022

It will eventually be appropriate to replace require() calls throughout the codebase with an ESM-CJS interoperable equivalent. I implemented that here to try to work around #34448, but it will not actually resolve that issue.

Bug

See #34448. Does not fix: It will take Tailwind merging changes into the tailwindcss library before Tailwind-related configs (incl. PostCSS) can be ESM and that specific issue can be resolved.

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ctjlewis/next.js import-interop Change
buildDuration 16.3s 16.3s ⚠️ +10ms
buildDurationCached 6.3s 6.3s ⚠️ +2ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ctjlewis/next.js import-interop Change
/ failed reqs 0 0
/ total time (seconds) 3.339 3.386 ⚠️ +0.05
/ avg req/sec 748.65 738.33 ⚠️ -10.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.431 1.446 ⚠️ +0.01
/error-in-render avg req/sec 1747.2 1728.33 ⚠️ -18.87
Client Bundles (main, webpack, commons)
vercel/next.js canary ctjlewis/next.js import-interop Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ctjlewis/next.js import-interop Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ctjlewis/next.js import-interop Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.04 kB 5.04 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ctjlewis/next.js import-interop Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ctjlewis/next.js import-interop Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ctjlewis/next.js import-interop Change
buildDuration 20.1s 20s -45ms
buildDurationCached 6.3s 6.3s -29ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ctjlewis/next.js import-interop Change
/ failed reqs 0 0
/ total time (seconds) 3.384 3.371 -0.01
/ avg req/sec 738.74 741.7 +2.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.491 1.438 -0.05
/error-in-render avg req/sec 1676.17 1738.41 +62.24
Client Bundles (main, webpack, commons)
vercel/next.js canary ctjlewis/next.js import-interop Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ctjlewis/next.js import-interop Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ctjlewis/next.js import-interop Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ctjlewis/next.js import-interop Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ctjlewis/next.js import-interop Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: ec7a8ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants